Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control when you want to focus initial date in Calendar #465

Closed
wants to merge 4 commits into from
Closed

Control when you want to focus initial date in Calendar #465

wants to merge 4 commits into from

Conversation

millnitzluan
Copy link

@millnitzluan millnitzluan commented Jun 12, 2018

  • I have changed my target branch to develop 👊

Closes #450

Screenshot

With shouldFocusDateInitially false:
with_false

With shouldFocusDateInitially true or without shouldFocusDateInitially:
without_prop

Description

Created prop to control when you want to focus initial date, the default value of shouldFocusDateInitially is true, so when you want to disable it, you only need to set to false.

@mcMickJuice
Copy link
Contributor

mcMickJuice commented Jun 12, 2018

This does not address #450. The idea of that issue is to be able to set a default "start date" whether that's in the past or future. Current behavior is if no value is provided, today's date is highlighted.

In what situations would you not want an initially focused date?

@millnitzluan
Copy link
Author

Yes @mcMickJuice. The initial idea is to open or not the datepicker with date highlight, start date is selected by date for example, if you send value as new Date (null) the starting date will be 1969 Wed, Dec 31

@mcMickJuice
Copy link
Contributor

@millnitzluan This is what I was thinking - #466

@millnitzluan
Copy link
Author

Ah sorry, when you said focused I was thinking in the button highlighted as second screenshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants