[palette] Better defensive logic (#12402)

mui · Aug 3, 2018 · f6036ed · f6036ed
1 parent 72716a5
commit f6036ed
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/packages/material-ui/src/styles/createPalette.js b/packages/material-ui/src/styles/createPalette.js
@@ -129,6 +129,16 @@ export default function createPalette(palette: Object) {
     if (!color.main && color[mainShade]) {
       color.main = color[mainShade];
     }
+
+    if (process.env.NODE_ENV !== 'production' && !color.main) {
+      throw new Error(
+        [
+          'Material-UI: the color provided to augmentColor(color) is invalid.',
+          `The color object needs to have a \`main\` property or a \`${mainShade}\` property.`,
+        ].join('\n'),
+      );
+    }
+
     addLightOrDark(color, 'light', lightShade, tonalOffset);
     addLightOrDark(color, 'dark', darkShade, tonalOffset);
     if (!color.contrastText) {

diff --git a/packages/material-ui/src/styles/createPalette.test.js b/packages/material-ui/src/styles/createPalette.test.js
@@ -361,4 +361,13 @@ describe('createPalette()', () => {
       /Material-UI: the palette type `foo` is not supported/,
     );
   });
+
+  describe('augmentColor', () => {
+    it('should throw when the input is invalid', () => {
+      const palette = createPalette({});
+      assert.throws(() => {
+        palette.augmentColor({});
+      }, /The color object needs to have a/);
+    });
+  });
 });