-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircularProgress sizing issue in a Dialog #11837
Comments
Please provide a full reproduction test case. This would help a lot 👷 . |
Here you go |
@oliviertassinari I could not re-open the issue myself, could you please re-open it |
I have been browsing the specification. I can no longer find any reference to the min-width value for the Dialog. I think that we can remove the property in |
@oliviertassinari I can make these changes and make a PR if that's OK? that'd be a good start for me to contributing to this library as well.. Edit: On it! :) |
This comment has been minimized.
This comment has been minimized.
@mim-Armand Let's us know if you are doing some progress :). |
Sorry for the delay! I've made the changes and all but got stuck on making the PR as wanted to make sure it's all perfect and couldn't figure out how to run the tests ( there were missing packages and multiple |
…re incorrect when rendered in a Dialog )
…re incorrect when rendered in a Dialog )
* attemting to fix Issue #11837 ( where the CircularProgress size were incorrect when rendered in a Dialog ) * changint the max-with to the calculated amount instead of using theme.spacing.unit * 8 * remove dialog action min-width
* attemting to fix Issue mui#11837 ( where the CircularProgress size were incorrect when rendered in a Dialog ) * changint the max-with to the calculated amount instead of using theme.spacing.unit * 8 * remove dialog action min-width
Expected Behavior
The
size
prop should set the size of the element.Current Behavior
The container element can not reduce the size of the SVG child the animation however is selected applied to the parent element which is "rendered" smaller. resulting to a wobbly animation effect
Steps to Reproduce (for bugs)
Here is an example in the codesandbox for MU
<CircularProgress size={18}/>
in the<DialogActions/>
elemntContext
N/A
Your Environment
The text was updated successfully, but these errors were encountered: