Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "bottom sheets" functionality #2126

Closed
markshust opened this issue Nov 11, 2015 · 8 comments
Closed

Implement "bottom sheets" functionality #2126

markshust opened this issue Nov 11, 2015 · 8 comments
Labels
new feature New feature or request

Comments

@markshust
Copy link
Contributor

I'd like to use a "fully expanded bottom sheet", ex. https://www.google.com/design/spec/components/bottom-sheets.html#bottom-sheets-modal-bottom-sheets

This functionality is quite needed for modal's that slide up from the bottom. I didn't notice it anywhere in the code.

@rkstar
Copy link

rkstar commented Nov 12, 2015

something like what materializecss has done would be perfect.

this is the code implementation of their leanModal component

@markshust
Copy link
Contributor Author

Similar to the bottom sheet style, yes. But also with fully expanded option to go full screen modal.

@justjacksonn
Copy link

May as well make it capable of any side, not just bottom, as well as center out, etc.

@markshust
Copy link
Contributor Author

I believe the material in this case is only supposed to be derived from the bottom up, as that is where the paper is coming from. I guess you can leave it up to the user though, to not follow this if they wish :)

@alitaheri alitaheri added new feature New feature or request design: material This is about Material Design, please involve a visual or UX designer in the process labels Dec 9, 2015
@mbrookes mbrookes added this to the next milestone Jan 17, 2017
@mbrookes mbrookes added the next label Jan 17, 2017
@chadfurman
Copy link

Where are we at with this ticket? It looks like I should just use https://github.com/TeamWertarbyte/material-ui-bottom-sheet

@oliviertassinari oliviertassinari removed the design: material This is about Material Design, please involve a visual or UX designer in the process label Jun 24, 2017
@oliviertassinari oliviertassinari removed this from the v1.0.0-prerelease milestone Jul 4, 2017
@xsh2047
Copy link

xsh2047 commented Jul 20, 2017

This component is very similar to the Drawer component, would we just refactor to incorporate the additional features or utilize it?

@kgregory
Copy link
Member

kgregory commented Aug 15, 2017

@chadfurman @markoshust As @zabieru96 points out, the Drawer component supports opening from the bottom (see demo).

This could be a decent starting point for you. To implement a fully-expanded bottom sheet using a drawer, you'd set anchor to bottom, override the anchorBottom class so that top is set to 0 instead of auto, and include a toolbar with a close button.

Perhaps this is all we'd need to do for an initial offering of BottomSheet:

  • wrap a bottom Drawer
  • expose a prop for fully-expanded behavior
  • make sure that the Drawer leaves room for the user to dismiss it when it is not set for full-expansion
  • make left and right auto and define a width at the large breakpoint (see: Tablet/Desktop)

@oliviertassinari I know you had done some nice work with bottom sheets before, what do you think?

@oliviertassinari
Copy link
Member

@kgregory One important limitation we have with the Drawer is that it's not supporting touch events. This is something we could fix later, but it's an important limitation on mobile. We can always build the feature on top of the Drawer, but this is going to require quite some work. We can also build the component on top of the Modal. That might be simpler. I can't say for sure without trying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

No branches or pull requests

9 participants