Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BottomSheet] Add BottomSheet component #4732

Closed
wants to merge 2 commits into from
Closed

[BottomSheet] Add BottomSheet component #4732

wants to merge 2 commits into from

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 16, 2016

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Continuation of #4336.
I'm writing down some point raised by @nathanmarks that I want to address before merging this PR.

  • usage of stage-1 for the documentation examples
  • use RenderToLayer/Portal to escape the parent workflow.
  • simplifying the layout computation
  • optionally keep the elements in the DOM when closed
  • open the SlidingSheet full screen.
  • rebase this PR to the next branch.

Closes #2862.
Closes #2126.

@oliviertassinari oliviertassinari changed the title Bottom sheep new [BottomSheet] Add BottomSheet component Jul 16, 2016
@oliviertassinari oliviertassinari added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Jul 19, 2016
@skirunman
Copy link
Contributor

Great that a bottomsheet is being added as a component! I see this includes a refactor of the drawer component. Any thoughts on supporting google navigation drawers of type Permanent, Persistent and Mini variant that all push the content to the right? See #4752

@muibot muibot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 22, 2016
@framerate
Copy link

I'm a big supporter of bottom sheet. Anything I can do to help with this PR?

@oliviertassinari
Copy link
Member Author

@framerate I have paused the development of this new component as it was missing some key points (the check-list). That was some time ago.

Now, we should also migrate it to the next branch.
Any help is welcomed! I have other priorities as this moment. Feel free to continue this PR 👍.

@oliviertassinari oliviertassinari removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 24, 2016
@muibot muibot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 26, 2016
@oliviertassinari oliviertassinari removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Nov 26, 2016
@oliviertassinari oliviertassinari deleted the bottom-sheep-new- branch November 26, 2016 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants