Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drawer] Improve FPS when swiping #2862

Closed
oliviertassinari opened this issue Jan 9, 2016 · 3 comments
Closed

[Drawer] Improve FPS when swiping #2862

oliviertassinari opened this issue Jan 9, 2016 · 3 comments
Labels
component: drawer This is the name of the generic UI component, not the React module! performance

Comments

@oliviertassinari
Copy link
Member

As it's well explains by google: https://developers.google.com/web/fundamentals/performance/rendering/optimize-javascript-execution?hl=en. We should use the requestAnimationFrame() API for reflecting visual changes when the user is draging the LeftNav.
One possible implementation is this one:
https://github.com/callemall/material-ui/blob/master/src/slider.jsx#L331

@mbrookes mbrookes changed the title [LeftNav] Improve FPS when swiping [Drawer] Improve FPS when swiping Mar 25, 2016
@oliviertassinari oliviertassinari added the component: drawer This is the name of the generic UI component, not the React module! label Dec 18, 2016
@oliviertassinari
Copy link
Member Author

Closing as we do no longer provide that feature on the next branch.

@mrkswrnr
Copy link

mrkswrnr commented Jul 2, 2017

Is there any discussion/reason for no longer providing the swipe feature on the next branch? I really liked the gesture support in 0.18

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 2, 2017

@mrkswrnr That was done for one main reason: that's making the implementation simpler. But that's not the end of the story, it would definitely be great to get the gesture support back as long as performance are acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: drawer This is the name of the generic UI component, not the React module! performance
Projects
None yet
Development

No branches or pull requests

3 participants