Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BottomNavigation vertical on large screens #6416

Closed
ajhool opened this issue Mar 22, 2017 · 1 comment
Closed

Make BottomNavigation vertical on large screens #6416

ajhool opened this issue Mar 22, 2017 · 1 comment
Labels
component: bottom navigation This is the name of the generic UI component, not the React module!

Comments

@ajhool
Copy link

ajhool commented Mar 22, 2017

Description

Material Guidelines suggest changing BottomNavigation (horizontal + bottom) to a (vertical + left) layout on larger displays like tablets and desktop. The need for this is clear when developing for a desktop -- it's simply not intuitive to have a bottom navigation bar. While not explicitly stated in the guidelines, I believe a toolbar would slide above and cover this component.

I propose a PR for:

  1. Adding an isVertical prop to the BottomNavigation component that defaults to false
  2. Adding a standard vertical style that is used when isVertical=true

Images & references

Usage section of Material Guidelines:
https://material.io/guidelines/components/bottom-navigation.html#bottom-navigation-usage

@kgregory
Copy link
Member

The guidelines state:

Larger displays, like desktop, may achieve a similar effect by using side navigation. For instance, the compact “rail” treatment displays navigational icons by default.

This excerpt complimented by an image depicting a mini-variant of the navigation drawer (scroll to mini-variant) with the following caption:

Left navigation on a larger display, such as tablet or desktop

The solution is to use the Drawer's mini-variant for tablet/desktop and BottomNavigation for mobile.
We should not add a vertical mode to BottomNavigation, it should remain specific and stay true to its name.

PR #7925 was recently approved and added the mini-variant to the Drawer. Since there is finally a solution, this case is closed.

@oliviertassinari oliviertassinari added the component: bottom navigation This is the name of the generic UI component, not the React module! label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: bottom navigation This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants