Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drawer] New improvements #7925

Merged
merged 1 commit into from
Aug 26, 2017
Merged

[Drawer] New improvements #7925

merged 1 commit into from
Aug 26, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 26, 2017

@Zuurkern Thanks a lot for your high-quality PR! It's a shame we couldn't merge it sooner.

Breaking change

-<Drawer docked />
+<Drawer type="persistent" />

aout-26-2017 20-47-42

Closes #7517 : I have disabled the gutter and manually applying the margin
Closes #6878 : This is a continuation
Closes #6767 : I had to implement this feature in order to speed up the "time to usefulness" by a factor of x2 🚀 . This means that the documentation has never been this fast. Step by step we are going to perform better than Bootstrap
Closes #6451 : Issue on the master version
Closes #6176 : Done, people can use the CSS implementation of Hidden (we use it for the docs)
Closes #6007 : This feature was removed (simpler to implement)
Closes #5603 : This feature was removed (simpler to implement)
Closes #4885 : This feature was removed (simpler to implement)
Closes #4773 : One more component ported 😄
Closes rstacruz/nprogress#186 : Fix the ngprogress rendering issue:
capture d ecran 2017-08-26 a 15 44 08

With YouTube version:

aout-26-2017 15-48-42

Before

capture d ecran 2017-08-31 a 00 55 48

After

capture d ecran 2017-08-31 a 00 55 58


  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari added component: drawer This is the name of the generic UI component, not the React module! v1 breaking change labels Aug 26, 2017
@rosskevin
Copy link
Member

Looks great @Zuurkern @oliviertassinari

@oliviertassinari
Copy link
Member Author

Sweet, all green 💃

@kgregory
Copy link
Member

Bravo!

@mehrdad-shokri
Copy link

@oliviertassinari is documentation up to date?
I can't find persistent prop on v1 docs

@oliviertassinari
Copy link
Member Author

Not released yet. We need to fix the documentation generation first.

@ToniIltanen
Copy link

Any info on the release?

@oliviertassinari
Copy link
Member Author

It was released two month ago.

@ToniIltanen
Copy link

In what version, i can't see these features in v0.19.4, and also not in the documentation?. The new Material-UI V1 lacks support for many existing components, so thats a no-no for switching at this point.

@mehrdad-shokri
Copy link

mehrdad-shokri commented Nov 2, 2017

@ToniIltanen it's released int 1.x.x-beta branch. In order to install it you need to change your material-ui version to next( or v1.0.0-beta.x).
Documentation is located at material-ui.com.
What components does it lack? AFAIK it doesn't support date and time picker yet(it use to have associated components in 0.x branch.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: drawer This is the name of the generic UI component, not the React module! component: Hidden The React component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants