[ListItemText] Fix primary={0} display #11686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Writing tests like the following fails: assert.strictEqual(
wrapper
.childAt(0)
.children()
.equals(0),
true,
'should have 0 as primary text',
);Any idea why? |
mbrookes
previously requested changes
Jun 2, 2018
| const hasPrimary = primaryProp || primaryProp === 0; | ||
| let primary = hasPrimary ? primaryProp : children; | ||
|
|
||
| if (hasPrimary && !disableTypography) { |
There was a problem hiding this comment.
Since hasPrimary is only true for primaryProp, this presumably won't work for children
oliviertassinari
changed the title
oliviertassinari
added
bug 🐛
|
I'm still confused why #11686 (comment) fails. Otherwise, the recent commit looks good to me! |
acroyear
pushed a commit
to acroyear/material-ui
that referenced
this pull request
Jul 14, 2018
* Display 0's with ListItemText * 🌹
This was referenced Nov 17, 2020
This was referenced Dec 1, 2020
This was referenced Jun 24, 2023
This was referenced Nov 30, 2023
This was referenced Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11672.