Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typography] Add a allVariants key in the theme #11802

Merged
merged 1 commit into from
Jun 11, 2018
Merged

[typography] Add a allVariants key in the theme #11802

merged 1 commit into from
Jun 11, 2018

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 10, 2018 •
edited
Loading

Based on the issue history and my needs at the office, it can be quite handy to be able to override all the variants at once. It's what theme.typography.variants is for. Use case: a global reset.

@mbrookes What do you think? Do you have a better wording in mind?

@oliviertassinari oliviertassinari added the new feature New feature or request label Jun 10, 2018
oliviertassinari
oliviertassinari commented Jun 10, 2018
View reviewed changes
packages/material-ui/src/Grid/Grid.js
// Close to the bootstrap implementation:
// https://github.com/twbs/bootstrap/blob/8fccaa2439e97ec72a4b7dc42ccc1f649790adb0/scss/mixins/_grid.scss#L41
/* eslint-enable max-len */
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead code

@oliviertassinari oliviertassinari self-assigned this Jun 10, 2018
@mbrookes
Copy link
Member

mbrookes commented Jun 11, 2018 •
edited
Loading

Tricky. Just some ideas (not saying these are better): theme.typography.allVariants, theme.typography.all, theme.typography.global, theme.typography.globalCSS?

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jun 11, 2018 •
edited
Loading

all, allVariants, I like that

@oliviertassinari oliviertassinari merged commit 3ba7256 into mui:master Jun 11, 2018
@oliviertassinari oliviertassinari deleted the typography-variants branch June 11, 2018 19:01
@oliviertassinari oliviertassinari changed the title [typography] Add a variants key in the theme [typography] Add a allVariants key in the theme Jun 11, 2018
@franklixuefei
Copy link
Contributor

Seems like the typescript definition is not updated. I'll fix it.

@franklixuefei franklixuefei mentioned this pull request Jun 21, 2018
Merged
acroyear pushed a commit to acroyear/material-ui that referenced this pull request Jul 14, 2018
@oliviertassinari
[typography] Add a variants key in the theme (mui#11802)
1854a2f
@snyk-bot snyk-bot mentioned this pull request Mar 7, 2020
Open
@hzhz hzhz mentioned this pull request Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookes mbrookes Awaiting requested review from mbrookes

Assignees

@oliviertassinari oliviertassinari

Labels
new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @mbrookes @franklixuefei