Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[styles] Safer prefix logic #11943

Merged
merged 1 commit into from
Jun 22, 2018
Merged

[styles] Safer prefix logic #11943

merged 1 commit into from
Jun 22, 2018
+18 −7

Conversation

oliviertassinari
Copy link
Member

Help with #11942.

@oliviertassinari oliviertassinari force-pushed the with-styles-safer-prefix branch from f369353 to 97043c9 Compare June 21, 2018 22:16
@oliviertassinari oliviertassinari added the new feature New feature or request label Jun 21, 2018
@oliviertassinari oliviertassinari merged commit 83ee54b into mui:master Jun 22, 2018
@oliviertassinari oliviertassinari deleted the with-styles-safer-prefix branch June 22, 2018 07:45
@jmcpeak
Copy link
Contributor

jmcpeak commented Jul 6, 2018

Hey - great fix - but we are using recompose along with some nested components - we hit that 100 character prefix already. I'd like to stop getting these console errors - maybe an option to turn off the warning?

@oliviertassinari
Copy link
Member Author

@jmcpeak As far as I have read the CSS specification, there is no max-length for a CSS selector. What's the length of your displayName. Can we get along by increasing the threshold?

@jmcpeak
Copy link
Contributor

jmcpeak commented Jul 6, 2018 •
edited
Loading

Yeah - bumping the limit would work as well.

Here's the longest one to date:

Connect(withState(withState(withState(withState(withProps(Connect(withProps(withHandlers(withHandlers(withHandlers(withHandlers(pure(PayerDetailScheduledTransactions)))))))))))))

256 seems reasonable?

@oliviertassinari
Copy link
Member Author

@jmcpeak Do you want to submit a pull request? :)

@jmcpeak
Copy link
Contributor

jmcpeak commented Jul 6, 2018

It's been awhile - but sure - I'll put on together tonight... :-)

@oliviertassinari
Copy link
Member Author

@jmcpeak Anytime you want

acroyear pushed a commit to acroyear/material-ui that referenced this pull request Jul 14, 2018
@oliviertassinari
[styles] Safer prefix logic (mui#11943)
9df6a61
@oliviertassinari oliviertassinari mentioned this pull request Jul 21, 2018
Merged
@snyk-bot snyk-bot mentioned this pull request Sep 30, 2019
Open
This was referenced Mar 26, 2020
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviertassinari @jmcpeak