[Tabs] Controllability in Tabs #1229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have been rendered
Make sure dialog is fully rendered before calling onShow
I can't find the border on the spec of material design.
[Avatar] remove border on images and use boxShadow
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
* Documentation improvements (mui#1229) * [docs] Show DateIOType instead of anys (mui#1228) * Show DateIOType instead of any in prop types tables * Update patrons list * Remove unused filter * Ovveride keyboard datepicker onChange date type * Update prop-types.json * Clarify TypeScript instructions for CSS overrides (mui#1257) * Fix MuiPickersOverrides import in CSS guide * Make instructions a little more dummy proof * Tidyup build config (mui#1309) * Tidyup build config - upgraded babel - upgraded rollup - fixed material-ui globals - replaced babel cli with rollup config with many entries - auto resolve named exports - skip non existent export warning - import correct (esm/cjs) babel helpers - error when material-ui global is not provided Here's generated build/esm/. Treeshaking should work fine. ``` Calendar-b9ae6101.js Calendar.js Clock-3486e4fb.js Clock.js ClockView.js DatePicker.js DateTimePicker.js Day.js Picker-429246aa.js Picker.js TimePicker.js TimePickerToolbar-e568e280.js Wrapper-12538b96.js index.js makePickerWithState-8a1dec7e.js useUtils-7fbeb79a.js ``` * Remove object-rest-spread
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
* Update packages * [typescript] Fix extending TextField issue * Master (mui#1314) * Documentation improvements (mui#1229) * [docs] Show DateIOType instead of anys (mui#1228) * Show DateIOType instead of any in prop types tables * Update patrons list * Remove unused filter * Ovveride keyboard datepicker onChange date type * Update prop-types.json * Clarify TypeScript instructions for CSS overrides (mui#1257) * Fix MuiPickersOverrides import in CSS guide * Make instructions a little more dummy proof * Tidyup build config (mui#1309) * Tidyup build config - upgraded babel - upgraded rollup - fixed material-ui globals - replaced babel cli with rollup config with many entries - auto resolve named exports - skip non existent export warning - import correct (esm/cjs) babel helpers - error when material-ui global is not provided Here's generated build/esm/. Treeshaking should work fine. ``` Calendar-b9ae6101.js Calendar.js Clock-3486e4fb.js Clock.js ClockView.js DatePicker.js DateTimePicker.js Day.js Picker-429246aa.js Picker.js TimePicker.js TimePickerToolbar-e568e280.js Wrapper-12538b96.js index.js makePickerWithState-8a1dec7e.js useUtils-7fbeb79a.js ``` * Remove object-rest-spread * Update packages * Fix typescript compilation errros
zannager
added
the
component: tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tabs are now controllable with this PR. Passing a value prop will allow you to programmatically choose which Tab is active or if no Tab is selected at all. If no value prop is passed, Tabs work normally as they have worked before this PR.
Breaking Changes: onChange(tabIndex, tab) now receives onChange(e, tab)
Fix: You can access the tabIndex of the tab by simply writing tabIndex = tab.props.tabIndex;