Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table] Padding feature #12415

Merged
merged 4 commits into from
Aug 7, 2018
Merged

[Table] Padding feature #12415

merged 4 commits into from
Aug 7, 2018

Conversation

aseem191
Copy link
Contributor

@aseem191 aseem191 commented Aug 5, 2018 •
edited by oliviertassinari
Loading

This pull request is a fix/addition for #12162, which adds a padding prop to Table, which allows TableCells to inherit the padding of the Table, but override if necessary.

Closes #12162

@oliviertassinari oliviertassinari added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI component: table This is the name of the generic UI component, not the React module! labels Aug 5, 2018
@aseem191
Added table padding feature.
c3d47a2 
Fixed omission of padding as a valid prop of Table.

Fixed read-only problems with padding.

Defined Padding.
@oliviertassinari oliviertassinari self-assigned this Aug 6, 2018
@oliviertassinari oliviertassinari added new feature New feature or request and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Aug 7, 2018
@oliviertassinari oliviertassinari merged commit 5cdc684 into mui:master Aug 7, 2018
@oliviertassinari
Copy link
Member

@aseem191 thanks

@franklixuefei
Copy link
Contributor

hmmmm, seems like a typescript definition leak here. I'll go fix this.

franklixuefei added a commit to franklixuefei/material-ui that referenced this pull request Aug 13, 2018
@franklixuefei
sync typings with mui#12415
53dcbb2
@franklixuefei franklixuefei mentioned this pull request Aug 13, 2018
Merged
oliviertassinari pushed a commit that referenced this pull request Aug 13, 2018
@franklixuefei @oliviertassinari
[Table] Sync typings with #12415 (#12503)
90fa749
@mbrookes mbrookes mentioned this pull request Feb 21, 2019
Merged
1 task
@snyk-bot snyk-bot mentioned this pull request Sep 30, 2019
Open
This was referenced Mar 26, 2020
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oliviertassinari oliviertassinari

Labels
component: table This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aseem191 @oliviertassinari @franklixuefei