-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[List] Use stable context API #13498
[List] Use stable context API #13498
Conversation
@eps1lon This looks great. I'm fixing the tests, at least, trying. |
c82264c
to
6cac0dc
Compare
6cac0dc
to
a122841
Compare
@eps1lon If you see anything that is wrong, feel free to raise it :). |
Thanks for cleaning that up! Didn't really have the time to follow through. I had a different approach though. Will open another PR to get your feedback. I think explicitly looking at a particular child of the component is not really the intention of some of those tests. As soon as we introduce another component into the tree it will likely break again. |
@eps1lon I ran out of ideas, if you think it can be improved, I'm all in! Also, It's likely that we will use the hook in the future to implement the feature. We need to be resilient to that change. I think that using mount over shallow is already a good first step. |
I find this error only throw out in particular case。 |
Part of #13394
Not a big fan of MergeWithListContext but ListItem would've been pretty bloated since it has two return statements.