Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Enable the i18n help messages #14356

Merged
merged 2 commits into from
Feb 1, 2019
Merged

[docs] Enable the i18n help messages #14356

merged 2 commits into from
Feb 1, 2019

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 30, 2019 •
edited
Loading

  • Enable the i18n help messages. We should wait a bit for merging the pull-request. People using an outdated version of the documentation will be spam of notifications.
  • Add two custom dimensions for GA so we can track the market share usage of each language and each code variant.
  • Explain the difference between a modal and a dialog.
  • Track sponsor logo clicks.
  • Only keep the valid languages.
  • Add follow and star buttons.
  • Add console easter egg.
  • Fix demo hover issue.
  • Add the new gold sponsor.
  • Fix some typos. Crowdin helps spotting issues.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jan 30, 2019
@oliviertassinari oliviertassinari force-pushed the docs-enable-i18n-message branch from d8c28e5 to 35088da Compare January 30, 2019 23:37
@mbrookes

This comment has been minimized.

Sign in to view
@oliviertassinari oliviertassinari mentioned this pull request Jan 31, 2019
Merged
2 tasks
@oliviertassinari oliviertassinari self-assigned this Jan 31, 2019
@oliviertassinari
Copy link
Member Author

@mbrookes Thank you for the feedback. I'm fixing it.

@oliviertassinari oliviertassinari force-pushed the docs-enable-i18n-message branch from 35088da to 4be7c48 Compare January 31, 2019 23:53
@oliviertassinari oliviertassinari removed their assignment Jan 31, 2019
@oliviertassinari oliviertassinari force-pushed the docs-enable-i18n-message branch from 4be7c48 to 02c2f93 Compare January 31, 2019 23:58
@oliviertassinari oliviertassinari merged commit 35bebb3 into mui:master Feb 1, 2019
@oliviertassinari oliviertassinari deleted the docs-enable-i18n-message branch February 1, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviertassinari @mbrookes