Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add button demos in ts #14739

Merged
merged 2 commits into from
Mar 5, 2019
Merged

[docs] Add button demos in ts #14739

merged 2 commits into from
Mar 5, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Mar 4, 2019

Closes #14707

@eps1lon eps1lon added docs Improvements or additions to the documentation typescript labels Mar 4, 2019
eps1lon
eps1lon commented Mar 4, 2019
View reviewed changes
packages/material-ui/src/styles/createSpacing.d.ts
(value1: SpacingArgument): SpacingReturnType;
(value1: SpacingArgument, value2: SpacingArgument): SpacingReturnType;
(value1: SpacingArgument, value2: SpacingArgument, value3: SpacingArgument): SpacingReturnType;
(value1: SpacingArgument): number;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/mui-org/material-ui/blob/a574657cb29a23594ad052fb78f972e6d3404586/packages/material-ui/src/styles/createSpacing.js#L37-L39

@oliviertassinari Were the typings wrong or the code?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typing I would say.

eps1lon
eps1lon commented Mar 4, 2019
View reviewed changes
docs/src/pages/demos/buttons/IconButtons.tsx
</IconButton>
<input accept="image/*" className={classes.input} id="icon-button-file" type="file" />
<label htmlFor="icon-button-file">
<IconButton color="primary" className={classes.button} component="span">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for #14707

@eps1lon eps1lon force-pushed the docs/button-ts-demos branch from ddd8714 to 990f9de Compare March 4, 2019 19:47
@mui-pr-bot
Copy link

No bundle size changes comparing a574657...004d95e

Generated by 🚫 dangerJS against 004d95e

@eps1lon eps1lon mentioned this pull request Mar 5, 2019
Merged
@oliviertassinari oliviertassinari merged commit 8d46415 into mui:next Mar 5, 2019
@eps1lon eps1lon deleted the docs/button-ts-demos branch March 15, 2019 11:03
@eps1lon eps1lon mentioned this pull request Mar 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari