Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Include innerRef breaking change in changelog #14771

Merged
merged 2 commits into from
Mar 6, 2019
Merged

[docs] Include innerRef breaking change in changelog #14771

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
523a865
[docs] Include `innerRef` breaking change in changelog
eps1lon Mar 6, 2019
024d668
include possible breakage
eps1lon Mar 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,15 @@ Here are some highlights ✨:
+<TableCell size="small" />
```

- Every component except `Dialog`, `MenuList`, `Modal`, `Popover` and `Tabs` forward
their `innerRef` (#14536).

This is implemented by using `React.forwardRef`. This affects the internal component
tree and display name and therefore might break shallow or snapshot tests.
`innerRef` will no longer return a ref to the instance
(or nothing if the inner component is a function component) but a ref to its root component.
The corresponding API docs list the root component.

### Changes

- [core] Improve a11y for Collapse, ExpansionPanel and Grow (#14598) @eps1lon
Expand Down