[docs] Add TypeScript demos for Simple and Spanning Table #14985
Conversation
|
I don't know what to do with spread operator in Source: |
oliviertassinari
changed the title
oliviertassinari
added
component: table
|
@hopelessmuffins Have made a new commit. Let me know what you think of the simplification proposal. |
|
No bundle size changes comparing d1a7d76...ae3fc37 |
|
Yep that works - I was wanting to change the |
| } | ||
|
|
||
| function subtotal(items) { | ||
| return items.map(({ price }) => price).reduce((sum, i) => sum + i, 0); | ||
| } | ||
|
|
||
| const rows = [ | ||
| ['Paperclips (Box)', 100, 1.15], | ||
| ['Paper (Case)', 10, 45.99], |
There was a problem hiding this comment.
I don't know what to do with spread operator in
SpanningTable.tsxbecause TypeScript considers the spread operator incompatible with the function signature ofcreateRow.Source:
Microsoft/TypeScript#4130
This was an issue with type widening. TypeScript inferred a nested array (string | number)[][] instead of an array of tuples [string, number, number][]. With TypeScript 3.4 we could've written ['Paper (Case)', 10, 45.99] as const to fix this issue.
| function createData(name, calories, fat, carbs, protein) { | ||
| id += 1; |
There was a problem hiding this comment.
That's a good change. The previous approach resulted in re-mounting of the TableRow on every render call of SimpleTable.
eps1lon
changed the title
eps1lon
changed the title
eps1lon
added
docs
|
@jasondashwang Much appreciated, thanks! |
This is my first time contributing to this project - before I continue adding TS demos, I want to make sure I am doing it correctly with my first two examples - SimpleTable and SpanningTable.