[Box] Use the default theme #15019
Merged
[Box] Use the default theme #15019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing f9896bc...b771d35 |
oliviertassinari
added
new feature
eps1lon
previously requested changes
Mar 23, 2019
eps1lon
approved these changes
Mar 23, 2019
|
Well, I know it is not a big deal nor super complex, but this is my first PR in a big open source project! Thanks for reviewing it so fast! Will try to collaborate more in the incoming weeks/months. |
oliviertassinari
changed the title
|
@apanizo It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR just changes the styled function on
Boxcomponent inmaterial-uicore. Basically, this PR has been created because using the Box component on test environments (Storybook, JEST Snapshots...) cause raised an exception due to defaultTheme was undefined.It closes #15005