-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add TypeScript demos for Dividers #15037
[docs] Add TypeScript demos for Dividers #15037
Conversation
I posted a few comments that should be resolved before merging. |
Have you submitted the comments? I can’t see any. |
@joshwooding Fixed that one! |
No bundle size changes comparing 60e0c31...5757321 |
@StevenGodin has contributed a pull request converting the same components in #15040. |
I'm proposing the following plan of action:
|
@eluchsinger Rebased, well done! |
We have a little error here, the "& WithTheme" declaration , the withStyles HOC don't automatically pass the theme as prop, so we are wrongly here, that type declaration should be type Props = WithStyles<typeof styles>; |
@saculbr Whoops! Nice spot, do you want to create a PR? |
Pull Request for the TypeScript conversion of the Dividers demo.
Edit @eps1lon:
Once #15040 is merged we need to rebase this with
next
before merge.