Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add TypeScript demos for Dividers #15037

Merged
merged 5 commits into from
Mar 25, 2019
Merged

[docs] Add TypeScript demos for Dividers #15037

merged 5 commits into from
Mar 25, 2019

Conversation

eluchsinger
Copy link
Contributor

@eluchsinger eluchsinger commented Mar 24, 2019

Pull Request for the TypeScript conversion of the Dividers demo.

Edit @eps1lon:
Once #15040 is merged we need to rebase this with next before merge.

@joshwooding joshwooding added docs Improvements or additions to the documentation typescript labels Mar 24, 2019
@eluchsinger eluchsinger changed the title [docs] Added typescript demo for InsetDividers [docs] Added typescript demo for Dividers Mar 24, 2019
@eluchsinger eluchsinger marked this pull request as ready for review March 24, 2019 18:55
@eluchsinger
Copy link
Contributor Author

I posted a few comments that should be resolved before merging.

@oliviertassinari oliviertassinari changed the title [docs] Added typescript demo for Dividers [docs] Add TypeScript demo for Dividers Mar 24, 2019
@oliviertassinari oliviertassinari changed the title [docs] Add TypeScript demo for Dividers [docs] Add TypeScript demos for Dividers Mar 24, 2019
@joshwooding
Copy link
Member

I posted a few comments that should be resolved before merging.

Have you submitted the comments? I can’t see any.

@eluchsinger
Copy link
Contributor Author

eluchsinger commented Mar 24, 2019

I posted a few comments that should be resolved before merging.

Have you submitted the comments? I can’t see any.

@joshwooding Fixed that one!

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 24, 2019

No bundle size changes comparing 60e0c31...5757321

Generated by 🚫 dangerJS against 5757321

@oliviertassinari
Copy link
Member

@StevenGodin has contributed a pull request converting the same components in #15040.

@eps1lon eps1lon added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 25, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 25, 2019

I'm proposing the following plan of action:

  1. We merge [Divider] Enable component generic props #15040 to fix the Divider TypeScript definitions.
  2. We rebase this pull request on top of it.
  3. We merge this pull request.

@oliviertassinari oliviertassinari removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 25, 2019
@oliviertassinari oliviertassinari merged commit cc856b6 into mui:next Mar 25, 2019
@oliviertassinari
Copy link
Member

@eluchsinger Rebased, well done!

@hexetia
Copy link
Contributor

hexetia commented Mar 26, 2019

We have a little error here, the "& WithTheme" declaration , the withStyles HOC don't automatically pass the theme as prop, so we are wrongly here, that type declaration should be

type Props = WithStyles<typeof styles>;

@joshwooding
Copy link
Member

joshwooding commented Mar 26, 2019

We have a little error here, the "& WithTheme" declaration , the withStyles HOC don't automatically pass the theme as prop, so we are wrongly here, that type declaration should be

type Props = WithStyles<typeof styles>;

@saculbr Whoops! Nice spot, do you want to create a PR?

@jztang jztang mentioned this pull request Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants