-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Switch][Radio][Checkbox] Improve specification compliance #15097
[Switch][Radio][Checkbox] Improve specification compliance #15097
Conversation
Details of bundle changes.Comparing: 2c2075e...3d263ef
|
34bb1b5
to
4228d27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #13799. I'm not handling it.
I don't understand that part. If you just close it without handling it you shouldn't reference it in a PR. This will appear in the issue as the PR that fixed the issue.
The box shadow has different color depending on the state. It is grey when not checked and primary/secondary when checked. Is this intended for a later PR or would this add to much implementation and that's why it is ignored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #13799. I'm not handling it.
I don't understand that part. If you just close it without handling it you shouldn't reference it in a PR. This will appear in the issue as the PR that fixed the issue.
The box shadow has different color depending on the state. It is grey when not checked and primary/secondary when checked. Is this intended for a later PR or would this add to much implementation and that's why it is ignored?
@eps1lon I'm suggesting a |
4228d27
to
3d263ef
Compare
I was not arguing against any of this. I know our roadmap. I have a problem with referencing an issue from a PR if that PR does not fix the issue. We can close the issue saying that we don't have a good solution for full spec compliance. But saying that this PR matches the spec and closing the issue is incorrect. |
@eps1lon I agree, it wasn't my intention. |
Closes #13799. We don't have a good solution for full spec compliance. Handling this case would make the implementation significantly more complex for a low ROI.
https://material.io/design/components/selection-controls.html#checkboxes
It was the occasion for me to dive into the customization of this component. Well boy, it's hard! I have refactored the implementation to make it easier to override the styles. I have renamed the class names to match the specification wording:
thumb instead of icon, track instead of bar.