Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add most Drawer TypeScript demos #15119

Merged
merged 1 commit into from
Apr 8, 2019
Merged

[docs] Add most Drawer TypeScript demos #15119

merged 1 commit into from
Apr 8, 2019

Conversation

cahilfoley
Copy link
Contributor

Add TypeScript demos for each of the existing Drawer demos for #14897

This is my first PR here 😄, let me know if there's anything I missed 🤙 .

@mui-pr-bot
Copy link

No bundle size changes comparing 2c2075e...bfc62e9

Generated by 🚫 dangerJS against bfc62e9

@oliviertassinari oliviertassinari changed the title [docs]: Add typescript version for each drawer demo [docs] Add TypeScript version for each drawer demo Mar 30, 2019
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: drawer This is the name of the generic UI component, not the React module! labels Mar 30, 2019
@eps1lon
Copy link
Member

eps1lon commented Mar 31, 2019

@cahilfoley This is currently missing ClippedDrawer. Since you said in the PR title this includes every drawer I guess you forgot to add one. Do you want to include this here or pass this to another PR/contributor?

@eps1lon eps1lon mentioned this pull request Mar 31, 2019
Closed
@eps1lon eps1lon changed the title [docs] Add TypeScript version for each drawer demo [docs] Add most Drawer TypeScript demos Apr 8, 2019
@eps1lon eps1lon merged commit 650ddda into mui:next Apr 8, 2019
@eps1lon
Copy link
Member

eps1lon commented Apr 8, 2019

@cahilfoley Much appreciated. Thanks. I merged this for house-keeping. The ClippedDrawer demo is still open if you want to work on it.

@cahilfoley
Copy link
Contributor Author

Sorry @eps1lon been pretty flat out with work, didn't realise I missed one, I'll add it in there now.

@cahilfoley cahilfoley mentioned this pull request Apr 9, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: drawer This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cahilfoley @mui-pr-bot @eps1lon @oliviertassinari