Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add ImgMediaCard TypeScript demo #15130

Merged
merged 13 commits into from
Apr 5, 2019
Merged

[docs] Add ImgMediaCard TypeScript demo #15130

merged 13 commits into from
Apr 5, 2019

Conversation

jasondashwang
Copy link
Contributor

@jasondashwang jasondashwang commented Mar 31, 2019 •
edited
Loading

jasondashwang
jasondashwang commented Mar 31, 2019
View reviewed changes
docs/src/pages/demos/cards/ImgMediaCard.tsx
return (
<Card className={classes.card}>
<CardActionArea>
<CardMedia
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting a TS compile error:

Type '{ component: "img"; alt: string; className: string; height: string; image: string; title: string; }' is not assignable to type 'IntrinsicAttributes & CardMediaProps & { children?: ReactNode; }'.
  Property 'alt' does not exist on type 'IntrinsicAttributes & CardMediaProps & { children?: ReactNode; }'.ts(2322)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to apply #15003 to CardMedia? cc @eps1lon

@jasondashwang
Copy link
Contributor Author

I think this might have reference to #15098 ?

@joshwooding joshwooding changed the title [docs] - Missing card TS demo [docs] Add ImgMediaCard TypeScript demo Mar 31, 2019
@joshwooding joshwooding added docs Improvements or additions to the documentation typescript labels Mar 31, 2019
@eps1lon eps1lon mentioned this pull request Mar 31, 2019
Merged
1 task
@eps1lon
Copy link
Member

eps1lon commented Mar 31, 2019

I think this might have reference to #15098 ?

See #15098 (comment) for the current status.

@eps1lon eps1lon self-assigned this Apr 4, 2019
@eps1lon eps1lon mentioned this pull request Apr 4, 2019
Closed
@mui-pr-bot
Copy link

No bundle size changes comparing 8db4931...a0adbc3

Generated by 🚫 dangerJS against a0adbc3

@jasondashwang
Copy link
Contributor Author

@eps1lon Does this require anything more on my end or are you handling it?

@eps1lon eps1lon merged commit d9d997c into mui:next Apr 5, 2019
@eps1lon
Copy link
Member

eps1lon commented Apr 5, 2019

@jasondashwang All good. Thanks for working on this. Much appreciated.

@eps1lon eps1lon mentioned this pull request Apr 5, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwooding joshwooding joshwooding left review comments

Assignees

@eps1lon eps1lon

Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasondashwang @eps1lon @mui-pr-bot @joshwooding