[docs] Add ExpansionPanels TypeScript Demo #15162

Adherentman · 2019-04-02T15:08:03Z

I have followed (at least) the PR section of the contributing guide.

mui-pr-bot · 2019-04-02T15:13:05Z

No bundle size changes comparing 240dc18...b254a2c

Generated by 🚫 dangerJS against b254a2c

oliviertassinari · 2019-04-02T15:26:24Z

docs/src/pages/demos/expansion-panels/DetailedExpansionPanel.js

@@ -67,7 +67,7 @@ function DetailedExpansionPanel(props) {
        <ExpansionPanelDetails className={classes.details}>
          <div className={classes.column} />
          <div className={classes.column}>
-            <Chip label="Barbados" className={classes.chip} onDelete={() => {}} />
+            <Chip label="Barbados" onDelete={() => {}} />


docs/src/pages/demos/expansion-panels/ControlledExpansionPanels.tsx

oliviertassinari · 2019-04-02T15:29:31Z

docs/src/pages/demos/breadcrumbs/RouterBreadcrumbs.js

@@ -106,7 +108,7 @@ class RouterBreadcrumbs extends React.Component {
              <List component="nav">
                <ListItemLink to="/inbox" open={this.state.open} onClick={this.handleClick} />
                <Collapse in={this.state.open} timeout="auto" unmountOnExit>
-                  <List component="div" disablePadding>
+                  <List component={'div'} disablePadding>


Something we could improve in the TypeScript to JavaScript logic generation.

I tried to change the js file directly, but I can't pass this ci. what should i do?

It's a topic for a different pull request. I was only raising the potential.

If it's fine with prettier it's fine with me

Adherentman · 2019-04-02T15:35:21Z

@oliviertassinari

  const [expanded, setExpanded] = React.useState<string | null>(null);

I use u suggest, but i got type and lint error:

Argument of type 'string | false' is not assignable to parameter of type 'SetStateAction<string | null>'.
  Type 'false' is not assignable to type 'SetStateAction<string | null>'.ts(2345)
TypeScript@next compile error: 
Argument of type 'string | false' is not assignable to parameter of type 'SetStateAction<string | null>'.
  Type 'false' is not assignable to type 'SetStateAction<string | null>'. (expect)tslint(1)

oliviertassinari · 2019-04-02T15:37:17Z

So, we are using null and false for no value? We can do better.

Adherentman · 2019-04-02T15:49:29Z

So, we are using null and false for no value? We can do better.

nice, I try

  const [expanded, setExpanded] = React.useState<string | false | null>(null);

no error!

oliviertassinari · 2019-04-02T17:27:42Z

@Adherentman That's one approach. I think that we can simplify the implementation here. cc @eps1lon.

We could replace the usage of false with null.

docs/src/pages/demos/expansion-panels/ControlledExpansionPanels.tsx

…s.tsx Co-Authored-By: Adherentman <adherentxu@gmail.com>

eps1lon

@Adherentman Could you rebase next again? Looks like this PR was based on #15139

…s.tsx Co-Authored-By: Adherentman <adherentxu@gmail.com>

…-ui into expansion-panels-ts

Adherentman · 2019-04-03T08:59:45Z

@Adherentman Could you rebase next again? Looks like this PR was based on #15139

yes, finished

eps1lon · 2019-04-03T09:02:11Z

@Adherentman Could you rebase next again? Looks like this PR was based on #15139

yes, finished

Doesn't look like it. Did you fetch the upstream before rebasing? If the rebase was successful there shouldn't be any Breadcrumbs related files appear in Files changed.

Adherentman · 2019-04-03T09:31:04Z

@Adherentman Could you rebase next again? Looks like this PR was based on #15139

yes, finished

Doesn't look like it. Did you fetch the upstream before rebasing? If the rebase was successful there shouldn't be any Breadcrumbs related files appear in Files changed.

I created a new pr. Because the previous repo was deleted by me. .

eps1lon

Must be the github UI then. Local comparison is clean.

Adherentman · 2019-04-03T09:45:32Z

Must be the github UI then. Local comparison is clean.

How can I do?

eps1lon · 2019-04-03T10:19:45Z

Must be the github UI then. Local comparison is clean.

How can I do?

You don't need to do anything. PR is in a good state.

Adherentman · 2019-04-03T10:22:21Z

Must be the github UI then. Local comparison is clean.

How can I do?

You don't need to do anything. PR is in a good state.

nice, Thank you

eps1lon · 2019-04-04T11:20:32Z

@Adherentman Thanks for sticking with it. Much appreciated, thanks!

Adherentman added 21 commits April 1, 2019 17:16

docs: Add breadcrumbs Typescript Demo

c7efe77

docs: yarn prettier breadcrumbs demo

fa9aacf

docs: format ts demo

86ba604

docs: format code

7704ab5

docs: fix eslint

851676d

Merge branch 'next' of github.com:mui-org/material-ui into next

926b451

docs: format js

611b951

docs: update ts file

fea3313

docs: fix js file

248dd19

fix ts import order

fc727d2

docs: fix ts demo

169bfd3

docs: yarn docs:typescript:formatted

755f00e

docs: fix lint

a9ec856

docs: fix lint

30faf84

fix lint

5795fd7

fix link error

97bb2ac

docs: fix eslint and ts type error

ae018fe

Merge branch 'next' of github.com:mui-org/material-ui into next

b750901

docs: fix ts and js

2a6602f

docs: Add ExpansionPanels TypeScript Demo

c406f0d

docs: prettier tsx

a3559c0

oliviertassinari added docs Improvements or additions to the documentation typescript labels Apr 2, 2019

oliviertassinari reviewed Apr 2, 2019

View reviewed changes

Adherentman added 3 commits April 2, 2019 23:39

docs: fix routerBreadcrumbs propTypes and list component

7465dc6

docs: yarn docs:typescript:formatted

63eb35b

docs: fix ControlledExpansionPanels useState types

b250068

eps1lon reviewed Apr 2, 2019

View reviewed changes

docs/src/pages/demos/expansion-panels/ControlledExpansionPanels.tsx Outdated Show resolved Hide resolved

eps1lon and others added 2 commits April 3, 2019 09:36

Update docs/src/pages/demos/expansion-panels/ControlledExpansionPanel…

94050f4

…s.tsx Co-Authored-By: Adherentman <adherentxu@gmail.com>

docs: pull and yarn docs:typescript:formatted

29f3ca4

eps1lon approved these changes Apr 3, 2019

View reviewed changes

oliviertassinari approved these changes Apr 3, 2019

View reviewed changes

eps1lon requested changes Apr 3, 2019

View reviewed changes

Adherentman and others added 6 commits April 3, 2019 16:55

docs: Add ExpansionPanels TypeScript Demo

df45611

docs: prettier tsx

0e579a2

docs: fix ControlledExpansionPanels useState types

01c0dc6

Update docs/src/pages/demos/expansion-panels/ControlledExpansionPanel…

4328f5e

…s.tsx Co-Authored-By: Adherentman <adherentxu@gmail.com>

docs: pull and yarn docs:typescript:formatted

908c876

Merge branch 'expansion-panels-ts' of github.com:Adherentman/material…

b254a2c

…-ui into expansion-panels-ts

eps1lon mentioned this pull request Apr 3, 2019

TypeScript demos #14897

Closed

eps1lon self-assigned this Apr 3, 2019

eps1lon approved these changes Apr 3, 2019

View reviewed changes

eps1lon mentioned this pull request Apr 3, 2019

[docs] Add ExpansionPanels TypeScript Demo #15173

Closed

1 task

eps1lon merged commit 239ceb9 into mui:next Apr 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[docs] Add ExpansionPanels TypeScript Demo #15162

[docs] Add ExpansionPanels TypeScript Demo #15162

Adherentman commented Apr 2, 2019

mui-pr-bot commented Apr 2, 2019 •

edited

Loading

oliviertassinari Apr 2, 2019

oliviertassinari Apr 2, 2019

Adherentman Apr 2, 2019

oliviertassinari Apr 2, 2019 •

edited

Loading

eps1lon Apr 2, 2019

Adherentman commented Apr 2, 2019

oliviertassinari commented Apr 2, 2019 •

edited

Loading

Adherentman commented Apr 2, 2019

oliviertassinari commented Apr 2, 2019 •

edited

Loading

eps1lon left a comment

Adherentman commented Apr 3, 2019

eps1lon commented Apr 3, 2019

Adherentman commented Apr 3, 2019

eps1lon left a comment

Adherentman commented Apr 3, 2019

eps1lon commented Apr 3, 2019

Adherentman commented Apr 3, 2019

eps1lon commented Apr 4, 2019

[docs] Add ExpansionPanels TypeScript Demo #15162

[docs] Add ExpansionPanels TypeScript Demo #15162

Conversation

Adherentman commented Apr 2, 2019

mui-pr-bot commented Apr 2, 2019 • edited Loading

oliviertassinari Apr 2, 2019

Choose a reason for hiding this comment

oliviertassinari Apr 2, 2019

Choose a reason for hiding this comment

Adherentman Apr 2, 2019

Choose a reason for hiding this comment

oliviertassinari Apr 2, 2019 • edited Loading

Choose a reason for hiding this comment

eps1lon Apr 2, 2019

Choose a reason for hiding this comment

Adherentman commented Apr 2, 2019

oliviertassinari commented Apr 2, 2019 • edited Loading

Adherentman commented Apr 2, 2019

oliviertassinari commented Apr 2, 2019 • edited Loading

eps1lon left a comment

Choose a reason for hiding this comment

Adherentman commented Apr 3, 2019

eps1lon commented Apr 3, 2019

Adherentman commented Apr 3, 2019

eps1lon left a comment

Choose a reason for hiding this comment

Adherentman commented Apr 3, 2019

eps1lon commented Apr 3, 2019

Adherentman commented Apr 3, 2019

eps1lon commented Apr 4, 2019

mui-pr-bot commented Apr 2, 2019 •

edited

Loading

oliviertassinari Apr 2, 2019 •

edited

Loading

oliviertassinari commented Apr 2, 2019 •

edited

Loading

oliviertassinari commented Apr 2, 2019 •

edited

Loading