[core] Synchronise value and checked prop typing

[joshwooding]

• I have followed (at least) the PR section of the contributing guide.

This allows for easier integration with redux-form without warning in the console.

const renderCheckBox = field => {
  return <Checkbox {...field.input} />;
};

instead of

const renderCheckBox = field => {
  const { input: { value, ...props} } = field;
  return <Checkbox value={String(value)} {...props} />;
};

Edit @eps1lon:
Closes #14286, #13782

[mui-pr-bot]

No bundle size changes comparing 8a67ecc...96a937c

Generated by 🚫 dangerJS against 96a937c

[joshwooding]

I've left the progress indicators and Slider value props as numbers

[eps1lon]

Sorry that I didn't mention that at first but we should use unknown for the types. I'm taking care of this as well as looking to event.target.value for select related components

[oliviertassinari]

Should we do the propTypes & TypeScript changes in two different pull requests?

[eps1lon]

They're both concerned with types. Since TypeScript is coupled with prop-types we should have them in one commit.

[oliviertassinari]

I agree in general. I was wondering as each commit would create value. I'm happy to move both as a whole.

[eps1lon]

At some point we should remove those. We usually don't document props from the root component. I guess keeping them here is more pragmatic. Once our docs are able to expand all props without having to keep multiple tabs open we can remove these here.

[oliviertassinari]

Correct, we break the rule to make the input component easier to use.

[eps1lon]

Radio and RadioGroup are a hot mess right now since we support them without the context. Without the context passing in any value doesn't do anything but within the context non-string values won't work as expected.

If we need any value support we should implement this in another PR. Right now anything but strings is dangerous because of JS weak typing.

[oliviertassinari]

What's wrong with any here?

[eps1lon]

See 757384e

[oliviertassinari]

Correct. We would need to cast the values to a string in the comparison to support any:

  let checked = checkedProp;
  const onChange = createChainedFunction(onChangeProp, radioGroup && radioGroup.onChange);
  let name = nameProp;

  if (radioGroup) {
    if (typeof checked === 'undefined') {
-     checked = radioGroup.value === props.value;
+     checked = String(radioGroup.value) === String(props.value);

I believe it's the only change required.

[eps1lon]

Have you looked at the test?

[oliviertassinari]

I have. My proposed change would only support string | number | boolean. But as you said, it's a topic for another pull request. Is this important? I'm not sure.

[eps1lon]

Pretty sure boolean would break easily and number is still dangerous.