Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix line ending issue on Windows #15433

Closed
wants to merge 3 commits into from
Closed

[docs] Fix line ending issue on Windows #15433

wants to merge 3 commits into from

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Apr 21, 2019 •
edited
Loading

When running yarn docs:typescript:formatted on Windows it leaves empty lines in files because git checkout saves them with \r\n.
Solution to this is to set endOfLine: 'lf', in prettier.config.js and eol=lf in .gitattributes

See https://prettier.io/docs/en/options.html#end-of-line for more

@merceyz merceyz changed the title [docs] Fix line ending regex in formattedTSDemos.js [docs] Fix line ending issue on Windows Apr 21, 2019
@mui-pr-bot
Copy link

No bundle size changes comparing 947853d...e6be872

Generated by 🚫 dangerJS against e6be872

@merceyz
Copy link
Member Author

merceyz commented Apr 21, 2019 •
edited
Loading

Closing in favour of #15438

@merceyz merceyz closed this Apr 21, 2019
@merceyz merceyz deleted the docs-formatted-ts-demos branch April 22, 2019 23:03
@zannager zannager added the docs Improvements or additions to the documentation label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@merceyz @mui-pr-bot @zannager