-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AppBar] Hide and Elevate on Scroll #15522
Conversation
Details of bundle changes.Comparing: 1ee592a...76171b8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Co-Authored-By: cvanem <chris@greenlinkservices.com>
Co-Authored-By: cvanem <chris@greenlinkservices.com>
@cvanem I have done the following changes:
|
How will it integrate with https://material-ui.com/demos/app-bar/#bottom-app-bar can we choose the direction of the scrolling and the behavior associated ? |
@adberard We could add a |
@oliviertassinari This looks excellent. You make it look easy. Do the tests look adequate? We may want to test scrollTop instead of pageYOffset when using mountWrapperWithRef. It shouldn't make a difference but that would be more representative of real world usage I believe. |
@cvanem I have barely updated the tests. If you feel they need more refinement, why not. |
@cvanem Great cooperation, thank you for pushing it forward! |
That's fantastic! Good job :) |
This is great to see! Any ideas on which version this will ship and timeframe? |
@ericvera This change will be released in v4.0.0-beta.1, today. |
Closes #12337
This PR does the following:
Add PaperProps to AppBar. This allows the underlying Paper className or classes to be overridden (for the elevate transitions).It turns out this was not actually needed.Please review as this is my first PR of substance.