Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[styles] Fix styled type definition not including properties #15548

Merged
merged 6 commits into from
Jun 10, 2019
Merged

[styles] Fix styled type definition not including properties #15548

merged 6 commits into from
Jun 10, 2019

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented May 1, 2019 •
edited
Loading

  • [styles] Fixed styled type definition not including properties
  • [docs] Added typescript version of styles/basics/AdaptingStyledComponents
  • [docs] Added typescript version of styles/basics/StyledComponents
  • [docs] Added typescript version of system/basics/JSS

@mui-pr-bot
Copy link

mui-pr-bot commented May 1, 2019 •
edited
Loading

No bundle size changes comparing 4516caf...3716237

Generated by 🚫 dangerJS against 3716237

@merceyz merceyz mentioned this pull request May 2, 2019
Merged
1 task
@merceyz
Copy link
Member Author

merceyz commented May 3, 2019

@eps1lon Review please

@eps1lon eps1lon added the package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. label May 6, 2019
@eps1lon eps1lon self-requested a review May 6, 2019 16:08
@eps1lon eps1lon added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label May 15, 2019
@eps1lon eps1lon closed this May 15, 2019
@eps1lon eps1lon reopened this May 15, 2019
@eps1lon
Copy link
Member

eps1lon commented May 15, 2019

@merceyz Are you still working on this?

@merceyz
Copy link
Member Author

merceyz commented May 15, 2019

@eps1lon No, I haven't had the time.

@mui-pr-bot
Copy link

mui-pr-bot commented May 15, 2019 •
edited
Loading

No bundle size changes comparing b0655d9...de1eba5

Generated by 🚫 dangerJS against de1eba5

@oliviertassinari
Copy link
Member

oliviertassinari commented May 19, 2019 •
edited
Loading

Should we close the pull request, for now? Does #15720 solve the same problem?

@Kujawadl Kujawadl mentioned this pull request May 20, 2019
Merged
1 task
@eps1lon
Copy link
Member

eps1lon commented May 20, 2019

Should we close the pull request, for now? Does #15720 solve the same problem?

We'll see. Everything is under control.

@oliviertassinari oliviertassinari changed the base branch from next to master May 23, 2019 21:09
@merceyz merceyz force-pushed the styles/styled branch 2 times, most recently from 0e9efdf to ef7ac30 Compare June 8, 2019 18:50
@merceyz
Copy link
Member Author

merceyz commented Jun 8, 2019

@eps1lon Works fine now, I noticed core/styles doesn't have a type definition for styled.js should I fix that while i'm at it, or do that in another PR?

@eps1lon eps1lon removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Jun 8, 2019
eps1lon
eps1lon reviewed Jun 8, 2019
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

styled in core should be another PR. Means less manually review when creating the changelog.

packages/material-ui-styles/src/styled/styled.d.ts Outdated Show resolved Hide resolved
@eps1lon eps1lon merged commit 109eff2 into mui:master Jun 10, 2019
@eps1lon eps1lon mentioned this pull request Jun 10, 2019
Closed
@merceyz merceyz deleted the styles/styled branch June 10, 2019 10:39
@merceyz merceyz mentioned this pull request Jun 10, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@merceyz @mui-pr-bot @eps1lon @oliviertassinari