Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add remaining TypeScript component demos #15755

Merged
merged 3 commits into from
May 21, 2019
Merged

[docs] Add remaining TypeScript component demos #15755

merged 3 commits into from
May 21, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented May 20, 2019 •
edited
Loading

Creating early prevent duplicate work being done.

TODO:

  • IntegrationDownshift
  • [ ] MenuPopupState no types for material-ui-popup-state
  • [ ] SwipeableTextMobileStepper no types for react-swipeable-views-utils
  • EnhancedTable
  • ReactVirtualizedTable

@eps1lon eps1lon added docs Improvements or additions to the documentation typescript labels May 20, 2019
@eps1lon eps1lon force-pushed the docs/ts-demos-remainder-actual branch from 8ef5183 to 7782a0d Compare May 20, 2019 10:07
@mui-pr-bot
Copy link

mui-pr-bot commented May 20, 2019 •
edited
Loading

No bundle size changes comparing 6b73158...0792b12

Generated by 🚫 dangerJS against 0792b12

@eps1lon eps1lon mentioned this pull request May 20, 2019
Closed
@eps1lon
Copy link
Member Author

eps1lon commented May 20, 2019

Removed a bunch of code from ReactVirtualizedTable that appeared to be unused. @joshwooding Could you take a look and check that I wasn't to overzealous with code removal?

@eps1lon eps1lon requested a review from joshwooding May 20, 2019 12:23
@eps1lon eps1lon marked this pull request as ready for review May 20, 2019 12:23
@joshwooding
Copy link
Member

LGTM, I guess there’s always a balance between showing a complete example with extras to guide customisation and trying to keep the demo simple and concise.

@eps1lon
Copy link
Member Author

eps1lon commented May 20, 2019

LGTM, I guess there’s always a balance between showing a complete example with extras to guide customisation and trying to keep the demo simple and concise.

I was wondering about that but we always kept the demos self-contained. I'd be happy to reintroduce some customization options but we should explain how to use it.

@eps1lon eps1lon merged commit f32d82e into mui:next May 21, 2019
@eps1lon eps1lon deleted the docs/ts-demos-remainder-actual branch May 21, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwooding joshwooding joshwooding approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @joshwooding