-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Popper] Fix anchorEl prop types #16004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove any notion of Element
now. Typing anchorEl
structurally with the ReferenceObject
seems sufficient. Element
is just an example implementation of the ReferenceObject
interface.
@eps1lon I haven't thought about this approach. Yeah, that sounds fair 👍. |
No bundle size changes comparing 64dab48...7c4f7ae |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would only mention BikeshedMyNamePlease1 and link to the API docs describing that interface.AnchorElement
1We can't use AnchorElement
because that points to an instance of <a />
. Maybe ReferenceObject
is better after all.
@eps1lon Maybe it's good enough as it is now? |
I mean you raised the concern so you should answer this. I was ok with ReferenceObject but offered another solution after concerns were raised. |
@eps1lon OK, after more digging, I'm fine with keeping ReferenceObject too :). |
I have updated the wording. Do you guys see something left to address? |
@dan8f It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
@oliviertassinari, quick PR to discuss your proposal #15922
Closes #15922