Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix withStyles not including props #16134

Merged
merged 5 commits into from
Jun 11, 2019
Merged

[core] Fix withStyles not including props #16134

merged 5 commits into from
Jun 11, 2019

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jun 10, 2019 •
edited
Loading

Alternative to #15953

  • [core] Fix withStyles not including properties
  • [styles] Fix withStyles not including properties
  • [styles] Fix PropsOfStyles not using CoerceEmptyInterface
  • [docs] Add typescript version of styles/basics/AdaptingHOC

Closes #15553
Closes #15953

@merceyz merceyz changed the title [core] Fixed withStyles and WithStyles not including properties [core] Fix withStyles and WithStyles not including properties Jun 10, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 10, 2019 •
edited
Loading

No bundle size changes comparing 06b4f34...b77cb66

Generated by 🚫 dangerJS against b77cb66

@merceyz merceyz force-pushed the styles/withStyles-props branch from 1fa8d24 to 97533f3 Compare June 10, 2019 12:05
@merceyz
Copy link
Member Author

merceyz commented Jun 10, 2019

Build passes in TypeScript v3.5.1, but not in v3.2.2 so I've reverted the change to WithStyles

@merceyz merceyz changed the title [core] Fix withStyles and WithStyles not including properties [core] Fix withStyles not including properties Jun 10, 2019
@eps1lon eps1lon mentioned this pull request Jun 10, 2019
Closed
@eps1lon eps1lon changed the title [core] Fix withStyles not including properties [core] Fix withStyles not including props Jun 11, 2019
@eps1lon eps1lon merged commit e61dc01 into mui:master Jun 11, 2019
@eps1lon
Copy link
Member

eps1lon commented Jun 11, 2019

@merceyz Much appreciated. Thanks.

@merceyz merceyz deleted the styles/withStyles-props branch June 11, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript type issue when adapting styles based on props with 'withStyles'
4 participants
@merceyz @mui-pr-bot @eps1lon @oliviertassinari