-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slider] Fix textAlign prop affecting Slider rail #16440
Conversation
Details of bundle changes.Comparing: 7fb9b40...9b37ad2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on it. Unfortunately the suggested change breaks the vertical slider.
Interesting, it's most likely linked to the issue reported by @leoyli #16416 (comment). Changing the text align reproduce a similar issue with the vertical slider. |
27a7593
to
9b37ad2
Compare
Sweet, thanks, that works. |
@mohan-cao It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
This change affects styling for the Slider component, and should fix #16437
I have looked over the tests but see that #16416 is still unmerged.
My first PR here, so feedback very welcome. :)
Closes #16437