Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add Media Query TS demo #17766

Merged
merged 2 commits into from
Oct 7, 2019
Merged

[docs] Add Media Query TS demo #17766

merged 2 commits into from
Oct 7, 2019

Conversation

lksilva
Copy link
Contributor

@lksilva lksilva commented Oct 7, 2019

No description provided.

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 7, 2019

No bundle size changes comparing 416b5f1...0b77827

Generated by 🚫 dangerJS against 0b77827

@eps1lon eps1lon added docs Improvements or additions to the documentation typescript labels Oct 7, 2019
@eps1lon
Copy link
Member

eps1lon commented Oct 7, 2019

@lksilva Thank you for working on this. It seems like you also rewrote the original demo using hooks. Please make sure that the corresponding .js file is converted as well.

That is why CI is failing: https://app.circleci.com/jobs/github/mui-org/material-ui/120140. For information about how to resolve this please check out #14897.

@oliviertassinari oliviertassinari changed the title [docs ]Add Media Query demos in ts [docs] Add Media Query demos in ts Oct 7, 2019
@eps1lon eps1lon changed the title [docs] Add Media Query demos in ts [docs] Add Media Query TS demo Oct 7, 2019
@eps1lon eps1lon mentioned this pull request Oct 7, 2019
@eps1lon eps1lon merged commit 4aea24a into mui:master Oct 7, 2019
@eps1lon
Copy link
Member

eps1lon commented Oct 7, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants