Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add Customization/Components TS demo #17788

Merged
merged 15 commits into from
Oct 9, 2019
Merged

[docs] Add Customization/Components TS demo #17788

merged 15 commits into from
Oct 9, 2019

Conversation

limatgans
Copy link
Contributor

@limatgans limatgans commented Oct 8, 2019 •
edited
Loading

Tests Passed

yarn docs:typescript:check and yarn docs:typescript:formatted

image

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 8, 2019 •
edited
Loading

No bundle size changes comparing 31d3008...803c103

Generated by 🚫 dangerJS against 803c103

@oliviertassinari oliviertassinari changed the title [docs]Migrate Customization/Components demo to TypeScript [docs] Migrate Customization/Components demo to TypeScript Oct 8, 2019
@oliviertassinari oliviertassinari force-pushed the limatgans/customization/components branch from 5e51e82 to 97e2457 Compare October 8, 2019 15:20
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation typescript labels Oct 8, 2019
@eps1lon eps1lon changed the title [docs] Migrate Customization/Components demo to TypeScript [docs] Add Customization/Components TS demo Oct 9, 2019
@eps1lon eps1lon mentioned this pull request Oct 9, 2019
Closed
@eps1lon eps1lon added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 9, 2019
@eps1lon
Copy link
Member

eps1lon commented Oct 9, 2019

@limatgans DynamicClassNames has been added in the meantime (#17793). Would you be so kind and update this PR and resolve merge conflicts?

@oliviertassinari oliviertassinari force-pushed the limatgans/customization/components branch from 97e2457 to 321753a Compare October 9, 2019 08:31
@oliviertassinari oliviertassinari removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 9, 2019
@oliviertassinari oliviertassinari added PR: ready to ship and removed docs Improvements or additions to the documentation typescript labels Oct 9, 2019
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation typescript labels Oct 9, 2019
@oliviertassinari oliviertassinari merged commit 2b9d278 into mui:master Oct 9, 2019
@oliviertassinari
Copy link
Member

@limatgans Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@limatgans @mui-pr-bot @eps1lon @oliviertassinari