Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add TS demos for SimpleNoSsr and FrameDeferring #17913

Merged
merged 6 commits into from
Oct 19, 2019
Merged

[docs] Add TS demos for SimpleNoSsr and FrameDeferring #17913

merged 6 commits into from
Oct 19, 2019

Conversation

ganes1410
Copy link
Contributor

I have added ts demos forSimpleNoSsr and FrameDeferring in this issue #14897.

@codesandbox-ci

This comment has been minimized.

Sign in to view
@codesandbox-ci

This comment has been minimized.

Sign in to view
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 17, 2019 •
edited
Loading

No bundle size changes comparing 7bd8216...bd5acfe

Generated by 🚫 dangerJS against bd5acfe

@codesandbox-ci

This comment has been minimized.

Sign in to view
eps1lon
eps1lon previously requested changes Oct 17, 2019
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just a minor note about resolving type issues concerning component return types.

docs/src/pages/components/no-ssr/FrameDeferring.tsx Outdated Show resolved Hide resolved
@eps1lon eps1lon added docs Improvements or additions to the documentation typescript labels Oct 17, 2019
@eps1lon eps1lon changed the title [Docs] : add ts demos for SimpleNoSsr and FrameDeferring [docs] Add TS demos for SimpleNoSsr and FrameDeferring Oct 17, 2019
@eps1lon eps1lon mentioned this pull request Oct 17, 2019
Closed
ganeshf22 and others added 2 commits October 18, 2019 11:20
oliviertassinari
oliviertassinari approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited by mbrookes
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It seemed that the deferred demo was broken. I have added the v3.x logic back to make it behave as it used to.
  • I have removed the use of makeStyles from the first demo.
  • I have fixed the layout wrap, it was broken at some point in the past.

@oliviertassinari oliviertassinari merged commit 5c70cfc into mui:master Oct 19, 2019
@oliviertassinari
Copy link
Member

@ganes1410 Thanks

@ganes1410
Copy link
Contributor Author

@eps1lon @oliviertassinari Thanks for the opportunity.😊

@ganes1410 ganes1410 deleted the no-ssr-typescript branch October 19, 2019 13:20
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ganes1410 @mui-pr-bot @oliviertassinari @eps1lon @ganeshf22