Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add TS demo for FormControlLabelPosition #17964

Merged
merged 3 commits into from
Oct 21, 2019
Merged

[docs] Add TS demo for FormControlLabelPosition #17964

merged 3 commits into from
Oct 21, 2019

Conversation

burtyish
Copy link
Contributor

Typescript demo for components/checkboxes: FormControlLabelPosition

#14897

Note: I removed the state management part

  1. FormGroup API does not accept name and value props.
  2. The state is not relevant for the point of the demo (which is positioning the label), potentially confusing IMO.

@burtyish burtyish changed the title [Checkbox] TS demo for FormControlLabelPosition [Checkbox] Add TS demo for checkboxes/FormControlLabelPosition Oct 20, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 20, 2019 •
edited
Loading

No bundle size changes comparing 7bbf61e...fad0959

Generated by 🚫 dangerJS against fad0959

@eps1lon eps1lon mentioned this pull request Oct 20, 2019
Closed
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation typescript labels Oct 20, 2019
@oliviertassinari oliviertassinari changed the title [Checkbox] Add TS demo for checkboxes/FormControlLabelPosition [Checkbox] Add TS demo for FormControlLabelPosition Oct 20, 2019
@oliviertassinari oliviertassinari merged commit 1e4d2db into mui:master Oct 21, 2019
@oliviertassinari
Copy link
Member

@burtyish Thank you!

@eps1lon eps1lon changed the title [Checkbox] Add TS demo for FormControlLabelPosition [docs] Add TS demo for FormControlLabelPosition Oct 21, 2019
@burtyish
Copy link
Contributor Author

@oliviertassinari I'm happy to contribute, you're all doing an amazing job maintaining this project

@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burtyish @mui-pr-bot @oliviertassinari