-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[system] Adding css grid support into style system #18023
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would allow users to simply create declarative css based grid components, as currently supported for flexbox. The container and item properties are separated to allow the use to choose if the component will support one of both elements of the grid system. Added to the Box component to remain consistent. see #9513
I'm willing to do the associated documentation additions/changes but want to check first that the code is correct and acceptable. |
@material-ui/core: parsed: +0.37% , gzip: +0.27% Details of bundle changes.Comparing: 77774ef...5904e6c
|
Closing as a duplicate of #17326. @stuarthendren Thank you for taking the time. Regarding #9513, it's about modernizing our Grid component (I think). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow users to simply create declarative
css based grid components, as currently supported for flexbox.
The container and item properties are separated to allow the use to choose
if the component will support one of both elements of the grid system.
Added to the Box component to remain consistent.
see #9513 CSS Grid Support