-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextField] Improve outlined transition #19228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
component: text field
This is the name of the generic UI component, not the React module!
design: material
This is about Material Design, please involve a visual or UX designer in the process
labels
Jan 14, 2020
I noticed the border-width transition as well when working on #17680. It seems like the border could use some anti-aliasing. Otherwise it doesn't look very smooth. I'm favoring removal of any border transition. |
Details of bundle changes.Comparing: c29c8ad...f6a7fc8
|
oliviertassinari
changed the title
Draft: try input animation changes
[TextField] Improve outlined transition
Jan 20, 2020
oliviertassinari
force-pushed
the
try-changes
branch
from
January 20, 2020 14:42
a5c4715
to
44cb763
Compare
oliviertassinari
force-pushed
the
try-changes
branch
from
January 21, 2020 09:14
44cb763
to
f6a7fc8
Compare
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Jan 23, 2020
This was referenced Mar 20, 2020
This was referenced Apr 6, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: text field
This is the name of the generic UI component, not the React module!
design: material
This is about Material Design, please involve a visual or UX designer in the process
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #17680.
Preview: https://deploy-preview-19228--material-ui.netlify.com/
I have looked closer at the animation of the input, from a global perspective. I have used https://accounts.google.com/signin/v2/identifier and https://material.io/components/text-fields/ to benchmark. It leads me to the following. I would love to get your perspective on them:
It seems that the spec encourages the shortest duration value (150ms) instead of the shorter (200ms)I have given up on the changes, it gives me motion sickness, it moves too fast. The animation in the specification video seems to run for 180ms.label
andlabelWidth
animation, to be closer. In particular, we could make both starts from the left edge. But I'm not too sure. Is the long term plan (v5) to remove thelabelWidth
's version? In which case, it doesn't really matter.