Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix some typos and correct a grammar mistake #19324

Merged
merged 2 commits into from
Jan 25, 2020
Merged

[docs] Fix some typos and correct a grammar mistake #19324

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02b4f3c
Fix typo
konekoya Jan 20, 2020
b099e00
review
joshwooding Jan 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ The core team is monitoring for Pull Requests. We will review your Pull Request
### How to increase the chance of being accepted?

CI runs a series of checks automatically when a Pull Request is opened. If you're not
sure if you changes will pass, you can always open a Pull Request and the GitHub UI will display a summary of
the results. If one of them fails check out the section [Checks and how to fix them](#checksfix).
sure if your changes will pass, you can always open a Pull Request and the GitHub UI will display a summary of
the results. If one of them fails, check out the section [Checks and how to fix them](#checksfix).
oliviertassinari marked this conversation as resolved.
Show resolved Hide resolved

Make sure the following is true:

Expand All @@ -99,7 +99,7 @@ Because we will only merge a Pull Request for which all tests pass. The followin

If any of the checks fails click on the _Details_
link and review the logs of the build to find out why it failed. The following
section gives an overview what each check is responsible for.
section gives an overview of what each check is responsible for.

##### ci/codesandbox

Expand Down Expand Up @@ -166,7 +166,7 @@ on _Details_ to find out more about them.

#### Caveats

##### Accessiblity tree exclusion
##### Accessibility tree exclusion

Our tests also explicitly document which parts of the queried element are included in
the accessibility (a11y) tree and which are excluded. This check is fairly expensive which
Expand Down