[FormControl] Add fullWidth prop to FormControl context
#19369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 1092c22...00753db
|
|
Looking into the argos failure... I'm not sure why MobileStepper might have a visual difference from these changes. |
|
@eps1lon @oliviertassinari From what I can tell, the argos failure is unrelated to my changes. I can't see any reason for this failure in the source for MobileStepper (the failing test was for TextMobileStepper) or any of its subcomponents. Seems like maybe the image that's being loaded changed? Really unsure. Can someone help me understand what's going on here? Cheers! |
EsoterikStare
commented
Jan 23, 2020
| @@ -224,6 +224,16 @@ describe('<FormControl />', () => { | |||
| setProps({ margin: 'dense' }); | |||
| expect(formControlRef.current).to.have.property('margin', 'dense'); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
This seems like it might be a good place for this additional test, but if there is a better way/location, let me know.
| type ContextFromPropsKey = | ||
| | 'disabled' | ||
| | 'error' | ||
| | 'fullWidth' |
There was a problem hiding this comment.
I'm not sure this is correct or even necessary, but it seems like a type update would be good to do for anything that returns the updated context object.
|
@EsoterikStare you're correct – it's an aberration. I've cleared the error. |
eps1lon
approved these changes
Jan 24, 2020
|
@EsoterikStare Great work on the PR. Reasonable feature, added tests, modified types. Nothing more to wish for 👍 |
EsoterikStare
added a commit
to EsoterikStare/material-ui
that referenced
this pull request
Feb 13, 2020
This was referenced Mar 10, 2020
This was referenced Apr 16, 2020
oliviertassinari
added
the
component: text field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion in #19336, I've added the
FormControlpropfullWidthto theFormControlcontext. I've also added a test to ensure this prop is present in the context and updated the type ofuseFormControl.I'm also not sure if there is any documentation to update. I don't see anything, but I may have missed something.