Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Add vietnamese (vi-VN) locale #19439

Merged
merged 6 commits into from
Jan 28, 2020
Merged

[l10n] Add vietnamese (vi-VN) locale #19439

merged 6 commits into from
Jan 28, 2020

Conversation

imcvampire
Copy link
Contributor

@imcvampire imcvampire changed the title Add vietnamese locale [l10n] Add vietnamese (vi-VN) locale Jan 28, 2020
oliviertassinari
oliviertassinari reviewed Jan 28, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

packages/material-ui/src/locale/index.d.ts Show resolved Hide resolved
packages/material-ui/src/locale/index.js Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari added the new feature New feature or request label Jan 28, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Jan 28, 2020 •
edited
Loading

No bundle size changes comparing f649826...7b10e12

Generated by 🚫 dangerJS against 7b10e12

@imcvampire
Copy link
Contributor Author

@oliviertassinari some things have happened with browser tests. Is there any bug on master because this PR doesn't change Select component

@oliviertassinari oliviertassinari merged commit 5c84559 into mui:master Jan 28, 2020
@oliviertassinari
Copy link
Member

Thank you, much appreciated

@imcvampire imcvampire deleted the patch-1 branch January 28, 2020 19:36
EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Feb 13, 2020
@imcvampire @oliviertassinari @EsoterikStare
[l10n] Add vietnamese (vi-VN) locale (mui#19439)
869d720 
* Update index.js

* Update index.d.ts

* Update localization.md

* Update index.d.ts

* Update index.js

* yarn prettier

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
This was referenced Feb 25, 2020
Closed
Merged
Merged
This was referenced Mar 10, 2020
Merged
Merged
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 22, 2020
Open
This was referenced Apr 16, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imcvampire @mui-pr-bot @oliviertassinari