Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationClose fixed #1945

Closed
wants to merge 1 commit into from
Closed

NavigationClose fixed #1945

wants to merge 1 commit into from

Conversation

c0b41
Copy link

@c0b41 c0b41 commented Oct 20, 2015

@oliviertassinari
Copy link
Member

@shaurya947 I'm not really sure we want to expose Icons from the index.js.

   Icons: {
     NavigationMenu: require('./svg-icons/navigation/menu'),
     NavigationChevronLeft: require('./svg-icons/navigation/chevron-left'),
     NavigationChevronRight: require('./svg-icons/navigation/chevron-right'),
   },

I would rather remove it. We have 100+ icons. Are we going to expose all of them?
I think that we shouldn't, hence for clarity may be better to not expose them at all from the index.

@shaurya947
Copy link
Contributor

@oliviertassinari I agree. It might be a better idea to have an index.js for the SVG icons instead.

@oliviertassinari
Copy link
Member

@shaurya947 Yeah, could be a good idea. And add them to the documentation. It would close this issue #1475

@c0b41 c0b41 closed this Oct 21, 2015
@shaurya947 shaurya947 mentioned this pull request Oct 21, 2015
@zannager zannager added the component: menu This is the name of the generic UI component, not the React module! label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants