-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Batch small changes #19717
Merged
oliviertassinari
merged 6 commits into
mui:master
from
oliviertassinari:batch-small-changes-v24
Feb 15, 2020
Merged
[core] Batch small changes #19717
oliviertassinari
merged 6 commits into
mui:master
from
oliviertassinari:batch-small-changes-v24
Feb 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oliviertassinari
commented
Feb 15, 2020
- [docs] There are 1,100 icons now 3df2bee: Google has been busy.
- [backers] Let's try a lower Diamond point 3d6d94f: Maybe it will better resonate.
- [job] Not knowing Material-UI can also be an advantage 532d638: Onboarding somebody that has a lot of experience with another UI framework could be as valuable as somebody that knows Material-UI strength and weaknesses => a new perspective.
- [Divider] Update flexItem description 56de4de: comment by @mbrookes.
- [docs] Clarify diff between select and autocomplete 40448de: I have seen this confusion come up multiple times
- [Portal] typeof Element doesn't work in iframe 639de37: Opened instanceOf(Element) doesn't work in iframe merceyz/typescript-to-proptypes#3.
oliviertassinari
added
the
umbrella
For grouping multiple issues to provide a holistic view
label
Feb 15, 2020
oliviertassinari
force-pushed
the
batch-small-changes-v24
branch
from
February 15, 2020 11:59
639de37
to
2ecbea4
Compare
No bundle size changes comparing c1c6690...2ecbea4 |
mbrookes
approved these changes
Feb 15, 2020
This was referenced Mar 10, 2020
This was referenced Mar 21, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.