[AvatarGroup] Add max avatar prop #19853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oliviertassinari Can you take a look at this when you get a chance? |
|
@material-ui/lab: parsed: +1.01% , gzip: +1.05% Details of bundle changes.Comparing: f27c78f...69f9942 Details of page changes
|
2 tasks
oliviertassinari
changed the title
oliviertassinari
added
component: avatar
oliviertassinari
previously requested changes
Feb 26, 2020
oliviertassinari
added
the
PR: needs revision
mbrookes
reviewed
Feb 26, 2020
There was a problem hiding this comment.
Playing with the prop descriptions. (It might inspire further tweaks. @joshwooding ?)
Also, it would be good to add a demo for the new functionality.
eps1lon
previously requested changes
Mar 1, 2020
|
@GFynbo Let us know if there is any blockers to complete the pull request :). |
|
@oliviertassinari Yup! Just some personal issues came up so I've been a little behind but will be finishing this up and pushing Friday/Sat. Sorry! |
Co-Authored-By: Matt <github@nospam.33m.co>
Co-Authored-By: Matt <github@nospam.33m.co>
oliviertassinari
removed
the
PR: needs revision
oliviertassinari
force-pushed
the
issue/18869-max
branch
from
fcb310a to
0546c18
Compare
oliviertassinari
force-pushed
the
issue/18869-max
branch
2 times, most recently
from
a46a63e to
d008c8e
Compare
oliviertassinari
approved these changes
Mar 15, 2020
There was a problem hiding this comment.
@GFynbo I have tried to apply the feedback suggested in the review. Let me know if it looks all right :)
oliviertassinari
force-pushed
the
issue/18869-max
branch
from
d008c8e to
69f9942
Compare
|
@oliviertassinari Looking through it now. Sorry for the delay!! The coronavirus is throwing things off. |
|
@oliviertassinari It looks good to me! Only consideration is to give a different name to the people in the docs example but it doesn't really matter since it's not showing up |
|
@GFynbo Nice work! |
This was referenced Mar 20, 2020
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Apr 10, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the max avatars displayed prop to the
AvatarGroupfor automatically adding an avatar with+xfunctionality. The default value is5and can be overridden withmax=x. The docs and examples have been updated.References #18869