Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pagination] Add TypeScript types #19933
[Pagination] Add TypeScript types #19933
Changes from 8 commits
f8bcc01
49c5d2b
4ca64c9
dfba109
1184e87
de59081
1cb8f7a
8d6d30f
61e1e30
a241b0f
c851ff9
770f5b9
6f4b0c9
3cf241e
044c60c
44a5e15
55aad9c
0e9f1c7
83178f5
f19cbe3
215f51c
4ef9bea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the types in the jsdoc? They duplicate the TS types and conflict in this case. It's also not clear when
type
can beundefined
while also having a default value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I thought that syntax somehow implied an optional argument. Will fix it in a sec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't remove the types from the jsdoc here. These docs are copied to the JS component by
yarn proptypes --disable-cache
, and then theyarn docs:api
command will fail because there is no type annotation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into adding support for this upstream, the parsing of basic types is complete but I stopped after a limited search for a
JSDoc -> AST -> JSDoc
lib failed.