Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Drawer] Add a comment for clarity on the styling of height of the toolbar #19934

Merged
merged 14 commits into from
Mar 3, 2020
Merged

[Drawer] Add a comment for clarity on the styling of height of the toolbar #19934

merged 14 commits into from
Mar 3, 2020

Conversation

smerriman18
Copy link
Contributor

@smerriman18 smerriman18 commented Mar 2, 2020 •
edited by oliviertassinari
Loading

Closes #19868

@mui-pr-bot
Copy link

No bundle size changes comparing 33a7c26...1cb77e3

Generated by 🚫 dangerJS against 1cb77e3

@oliviertassinari oliviertassinari added component: drawer This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation PR: ready to ship labels Mar 2, 2020
@oliviertassinari oliviertassinari changed the title [Drawer] Adding a comment for clarity on the styling of height of the toolbar [Drawer] Add a comment for clarity on the styling of height of the toolbar Mar 3, 2020
@oliviertassinari oliviertassinari merged commit fac9562 into mui:master Mar 3, 2020
@oliviertassinari
Copy link
Member

@smerriman18 Thanks

This was referenced Mar 20, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Mar 30, 2020
@smerriman18 @EsoterikStare
[Drawer] Add a comment for clarity on the styling of height of the to…
8885039 
…olbar (mui#19934)
This was referenced Apr 10, 2020
Closed
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: drawer This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Drawer] Confusing drawer documentation
3 participants
@smerriman18 @mui-pr-bot @oliviertassinari