-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump prettier to 2.0.0 #20211
Bump prettier to 2.0.0 #20211
Conversation
also refactos process.exit to throw Error which is gracefully handled by yargs
This reverts commit ba4ebc2.
.prettierrc
Outdated
"semi": true, | ||
"singleQuote": true, | ||
"trailingComma": "all", | ||
"arrowParens": "avoid" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default in 2.0.0 is always
. This would introduce 600 changed filed. I guess we already agreed to not follow it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be in favor of using the default
"arrowParens": "avoid" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me so happy :D Let's do this and get rid of the explicit defaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, singleQuote and trailingComma seems the only two we need to keep? https://github.com/facebook/react/blob/master/.prettierrc.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it matches (more or less) the format of the demos in https://reactjs.org/, we should be fine.
Details of bundle changes.Comparing: 8b32809...d66b422 Details of page changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet :
.prettierrc
Outdated
"semi": true, | ||
"singleQuote": true, | ||
"trailingComma": "all", | ||
"arrowParens": "avoid" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be in favor of using the default
"arrowParens": "avoid" |
Let's get this in before it drowns in merge conflicts. |
yarn prettier
(like [docs] Document typescript:transpile script #19951)