-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Warn when value does not match options #20235
Merged
oliviertassinari
merged 2 commits into
mui:master
from
igorbrasileiro:feature/warn-autocomplete-valid-value
Mar 23, 2020
Merged
[Autocomplete] Warn when value does not match options #20235
oliviertassinari
merged 2 commits into
mui:master
from
igorbrasileiro:feature/warn-autocomplete-valid-value
Mar 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 7e1da61...f17d5c6 Details of page changes
|
oliviertassinari
added
the
component: autocomplete
This is the name of the generic UI component, not the React module!
label
Mar 22, 2020
oliviertassinari
changed the title
[Autocomplete] add warn when value does not in options
[Autocomplete] Warn when value does not match options
Mar 22, 2020
oliviertassinari
force-pushed
the
feature/warn-autocomplete-valid-value
branch
from
March 22, 2020 19:58
b19d5e9
to
dd0f694
Compare
return consoleSpy.args.map((loggerArgs) => { | ||
return utilFormat(...loggerArgs); | ||
}); | ||
}; | ||
} | ||
|
||
export default new ConsoleErrorMock(); | ||
export const consoleWarnMock = new ConsoleMock('warn'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A reminder that we need to advance #15343.
oliviertassinari
approved these changes
Mar 22, 2020
oliviertassinari
force-pushed
the
feature/warn-autocomplete-valid-value
branch
from
March 22, 2020 20:05
dd0f694
to
f17d5c6
Compare
@igorbrasileiro Well done, thanks! |
Thank you too |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Mar 30, 2020
This was referenced Apr 7, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: autocomplete
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #18514
This PR adds warn and a single test to check it.
example that will throw a warn: