-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Select] Don't fire onChange if current value #20361
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksrb
force-pushed
the
select-onChange-fix
branch
from
March 31, 2020 17:32
acb5d17
to
13b8cb8
Compare
ksrb
force-pushed
the
select-onChange-fix
branch
from
March 31, 2020 17:34
13b8cb8
to
11d3452
Compare
oliviertassinari
added
the
component: select
This is the name of the generic UI component, not the React module!
label
Mar 31, 2020
oliviertassinari
approved these changes
Mar 31, 2020
Details of bundle changes.Comparing: 5aad5f2...11d3452 Details of page changes
|
@ksrb It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
This was referenced Apr 6, 2020
This was referenced Apr 13, 2020
2 tasks
2 tasks
This comment has been minimized.
This comment has been minimized.
oliviertassinari
changed the title
[Select] onChange fired with current value
[Select] Don't fire onChange if current value
Apr 27, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20351, thanks oliviertassinari 😄
Edit: Force pushes are changing the git author stuff (work laptop and all that)