[theme] Fix types to pass array for spacing #20486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denys-pavlenko
changed the title
oliviertassinari
approved these changes
Apr 9, 2020
Details of bundle changes.Comparing: 89f6208...dd609f7 Details of page changes
|
eps1lon
reviewed
Apr 10, 2020
| @@ -15,6 +15,6 @@ export interface Spacing { | |||
| ): string; | |||
| } | |||
|
|
|||
| export type SpacingOptions = number | ((factor: number) => string | number); | |||
| export type SpacingOptions = number | ((factor: number) => string | number) | number[]; | |||
There was a problem hiding this comment.
If I understand the implementation that this is just forwarded to @material-ui/system, right? Seems like we should type createUnarySpacing at some point and use that type in /core.
There was a problem hiding this comment.
Should we do this change here?
There was a problem hiding this comment.
I don't feel strongly about it. Up to anybody who's interested in either method.
There was a problem hiding this comment.
Cool, I suggest one step at the time in this case :). @denys-pavlenko Feel free to send a follow-up. Maybe we should start by breaking down the index.d.ts to be closer to the source
https://github.com/mui-org/material-ui/blob/master/packages/material-ui-system/src/index.d.ts
?
oliviertassinari
changed the title
|
@denys-pavlenko Thanks for the follow-up |
This was referenced Apr 13, 2020
This was referenced Apr 20, 2020
This was referenced May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complements #19900